-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Google Consent Mode [DOC-839] #6164
Conversation
✅ Deploy Preview for segment-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Left a couple of comments. Could we also replace the info banner with, Google is enforcing consent starting March 6th and here are instructions to implement this with a link in the docs to the consent section. We can plan to remove this in the future, but just so it is easier for customers to find it
src/connections/destinations/catalog/google-tag-manager/index.md
Outdated
Show resolved
Hide resolved
src/connections/destinations/catalog/google-ads-classic/index.md
Outdated
Show resolved
Hide resolved
src/connections/destinations/catalog/personas-display-video-360/index.md
Outdated
Show resolved
Hide resolved
src/connections/destinations/catalog/actions-google-analytics-4/index.md
Outdated
Show resolved
Hide resolved
src/connections/destinations/catalog/actions-google-analytics-4-web/index.md
Outdated
Show resolved
Hide resolved
* **Option 1:** | ||
1. Navigate to **Connections > Destinations** and select your Google Analytics 4 Web destination. | ||
2. Go to the **mappings** tab of the destination. | ||
3. Select the mapping you want to edit.' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3. Select the mapping you want to edit.' | |
3. Select the Set Configuration Mapping to edit.' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I disagree with this step, it should be that they select the mapping they want to edit
src/connections/destinations/catalog/actions-google-analytics-4-web/index.md
Outdated
Show resolved
Hide resolved
src/connections/destinations/catalog/actions-google-analytics-4-web/index.md
Outdated
Show resolved
Hide resolved
…4/index.md Co-authored-by: rvadera12 <[email protected]>
Co-authored-by: rvadera12 <[email protected]>
…0/index.md Co-authored-by: rvadera12 <[email protected]>
src/connections/destinations/catalog/google-ads-classic/index.md
Outdated
Show resolved
Hide resolved
Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site. |
Proposed changes
Merge timing
Related issues (optional)